Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't quote uppercase strings #1073

Closed
wants to merge 1 commit into from
Closed

fix: Don't quote uppercase strings #1073

wants to merge 1 commit into from

Conversation

max-sixty
Copy link
Member

This is a temporary workaround for @mklopets & team, while we resolve #820.

@aljazerzen -- not sure if you think this is an acceptable tradeoff? I'll wait for your review.

This is a temporary workaround for @mklopets & team, while we resolve #820.

@aljazerzen -- not sure if you think this is an acceptable tradeoff? I'll wait for your review.
@max-sixty
Copy link
Member Author

Sounds like @mklopets already has a workaround, so maybe this isn't worth merging.

But @mklopets if it's 5x easier to change something in PRQL than your lib, then fine to change it in PRQL, even if it's not in the right direction for a narrow definition of correctness.

@aljazerzen
Copy link
Member

As I said on discord, I would prefer if PRQL would remain case sensitive.

@max-sixty
Copy link
Member Author

As I said on discord, I would prefer if PRQL would remain case sensitive.

OK, given @mklopets has a workaround to the s-string issue, I'm closing

@max-sixty max-sixty closed this Oct 24, 2022
@max-sixty max-sixty deleted the caps branch October 28, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same column name in multiple tables causes buggy behaviour
2 participants