Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use tags for the language code blocks #2350

Merged
merged 4 commits into from
Mar 30, 2023

Conversation

max-sixty
Copy link
Member

Idea from #2348

@eitsupi
Copy link
Member

eitsupi commented Mar 30, 2023

Great!

I checked CommomMark Spec and found that it mentions spaces as delimiter (info string).
https://spec.commonmark.org/0.30/#example-143

Could the delimiter be a space?

~~~~    ruby startline=3 $%@#$
def foo(x)
  return 3
end
~~~~~~~

to

<pre><code class="language-ruby">def foo(x)
  return 3
end
</code></pre>

startline=3 $%@#$ is ignored.

@max-sixty
Copy link
Member Author

Changed to spaces!

@max-sixty max-sixty enabled auto-merge (squash) March 30, 2023 17:48
@max-sixty max-sixty merged commit 8d46f6b into PRQL:main Mar 30, 2023
@max-sixty max-sixty deleted the book-tags branch March 30, 2023 17:54
max-sixty added a commit to max-sixty/prql that referenced this pull request Apr 2, 2023
* refactor: Use tags for the language code blocks

Idea from PRQL#2348

* change to spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants