Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: infering modules and treating them as SQL schemas #2563

Merged
merged 9 commits into from
May 12, 2023
Merged

feat!: infering modules and treating them as SQL schemas #2563

merged 9 commits into from
May 12, 2023

Conversation

aljazerzen
Copy link
Member

@aljazerzen aljazerzen commented May 11, 2023 •
edited
Loading

  • Squashed commit of the following
  • infer modules
  • make table reference an Ident instead of String

Closes #1535

A big commit, I had to tweak how we do inference.

A thought: should we throw an error when a table name ends in .parquet or .csv? It'd be nice to redirect users toward read_parquet or read_csv.

@aljazerzen
Squashed commit of the following:
9b0a12d 
commit fa0cd5a
Author: Maximilian Roos <m@maxroos.com>
Date:   Mon May 1 23:09:42 2023 -0700

    Remove incorrect changes

commit 43ef350
Author: Maximilian Roos <m@maxroos.com>
Date:   Mon May 1 13:18:56 2023 -0700

commit add9350
Merge: c93f490 eeba72c
Author: Maximilian Roos <m@maxroos.com>
Date:   Mon May 1 13:09:27 2023 -0700

    Merge branch 'main' into 1535

commit c93f490
Merge: e31e42b b162a51
Author: Maximilian Roos <m@maxroos.com>
Date:   Fri Apr 14 09:21:46 2023 -0700

    Merge branch 'main' into 1535

commit e31e42b
Merge: ccfb43c c9c077d
Author: Maximilian Roos <m@maxroos.com>
Date:   Sat Apr 8 18:51:16 2023 -0700

    Merge branch 'main' into 1535

commit ccfb43c
Merge: 0c2d751 2125923
Author: Maximilian Roos <m@maxroos.com>
Date:   Sat Apr 1 20:16:05 2023 -0700

    Merge branch 'main' into 1535

commit 0c2d751
Author: Maximilian Roos <m@maxroos.com>
Date:   Sat Apr 1 16:09:26 2023 -0700

commit d7a4db0
Author: Maximilian Roos <m@maxroos.com>
Date:   Sat Apr 1 14:49:02 2023 -0700

    .

commit dfc2fe2
Author: Maximilian Roos <m@maxroos.com>
Date:   Sat Apr 1 13:16:17 2023 -0700

commit 7720293
Merge: 5ab1a89 a65f633
Author: Maximilian Roos <m@maxroos.com>
Date:   Sat Apr 1 00:17:06 2023 -0700

    Merge branch 'main' into 1535

commit 5ab1a89
Author: Maximilian Roos <m@maxroos.com>
Date:   Fri Mar 31 14:45:26 2023 -0700
@aljazerzen
infer modules
e0b46bc
@aljazerzen
make table reference an Ident instead of String
b2b4eb2
@aljazerzen aljazerzen changed the title opaque idents feat: infering modules and treating them as SQL schemas May 11, 2023
@aljazerzen aljazerzen changed the title feat: infering modules and treating them as SQL schemas feat!: infering modules and treating them as SQL schemas May 11, 2023
@aljazerzen aljazerzen mentioned this pull request May 11, 2023
Closed
aljazerzen and others added 3 commits May 11, 2023 21:06
@aljazerzen @max-sixty
Update prql-compiler/src/ast/pl/ident.rs
cecbbd5 
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
@aljazerzen
docs
fd8c517
@aljazerzen
fmt
e05ac3d
@aljazerzen aljazerzen enabled auto-merge (squash) May 12, 2023 09:12
@aljazerzen aljazerzen merged commit c440ae2 into main May 12, 2023
@aljazerzen aljazerzen deleted the opaque-idents branch May 12, 2023 17:50
@max-sixty
Copy link
Member

I've been going through my notifications and I found an unsent comment on this — thank you very much indeed @aljazerzen — I found this a pervasive issue for the lang, now solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve opaqueness of idents
2 participants
@aljazerzen @max-sixty