This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Refactor playerItem KVO registration #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mediaPlayerDidChange:` method is removed since it was only being called by the `PRXPlayerAVPlayerContext` notification which is no longer registered on any key path. The functionality in `mediaPlayerDidChange:` had previously been moved to the `setPlayer:` method.
In order to keep proper accounting of observers added and removed from the `AVPlayerItem` in the current player, the `mediaPlayerCurrentItemDidChange:` method that is called on a player item change now utilizes the change dictionary to get the old and new items and register and deregister notifications appropriately. In order for this to also work on player change notifications, a dummy change dictionary is constructed and passed along.
| } | ||
|
|
||
| dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{ | ||
| playerPeriodicTimeObserver = [self.player addPeriodicTimeObserverForInterval:CMTimeMakeWithSeconds(1, 1000) queue:self.class.sharedQueue usingBlock:^(CMTime time) { |
There was a problem hiding this comment.
Sorry if I'm missing something, but if this observer is getting removed, what is happening to update progress bars/etc?
There was a problem hiding this comment.
All of the functionality from this method is duplicated in setPlayer:, for example: https://github.com/jballanc/PRXPlayer/blob/master/PRXPlayer.m#L153
farski
added a commit
that referenced
this pull request
Nov 2, 2014
Refactor playerItem KVO registration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.