Update dev setup documentation #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought I remembered blank values in database.yml for |
| @@ -50,10 +53,13 @@ echo 'eval "$(rbenv init -)"' >> ~/.bash_profile | |||
| source ~/.bash_profile | |||
|
|
|||
| # ruby (.ruby-version default) | |||
| rbenv install | |||
| rbenv install 2.1.2 | |||
There was a problem hiding this comment.
I think that if .ruby-version is present in the directory you run rbenv install in (which it is if you're in a checkout for this project) rbenv install is technically more correct than rbenv install 2.1.2. That said, the ordering on this is a little wonky, so maybe good to specify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating README with my experience installing the dev environment.
Also changes
database.ymlto allow a password on the test database ... which may or may not break the build. We'll find out!