Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async validations #622

Merged
merged 11 commits into from
Apr 27, 2023
Merged

Async validations #622

merged 11 commits into from
Apr 27, 2023

Conversation

cavis
Copy link
Member

@cavis cavis commented Apr 24, 2023 •
edited
Loading

After #619.

Part of #618.

  • Adds an invalid image/audio status
  • Catch validation errors in Porter callbacks, and change status from complete to invalid
  • Refactoring to standardize MediaResource vs ImageFile

@cavis cavis changed the base branch from main to feat/image_uploads April 25, 2023 16:32
svevang
svevang approved these changes Apr 27, 2023
View reviewed changes
app/models/tasks/copy_image_task.rb
end

image_resource.save!
podcast.try(:publish!) if image_resource.status_complete?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from feat/image_uploads to main April 27, 2023 17:41
@cavis cavis merged commit 98c3809 into main Apr 27, 2023
@cavis cavis deleted the feat/async_validations branch April 27, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svevang svevang svevang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cavis @svevang