-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ryp2 dependency #110
Conversation
The error I was getting was in the OG-Lifespan repository in the GH Action that ran the CI tests. In the "Setup Miniconda" job of the CI test, the following error arose, which seemed to be related to rpy2. When scanning the rpy2 repository Issues, I found this one "problem installing on mac" that suggested updated the package.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 75.35% 75.49% +0.14%
==========================================
Files 11 11
Lines 852 857 +5
==========================================
+ Hits 642 647 +5
Misses 210 210
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@jdebacker. All the tests are passing now locally on my Mac machine. I looked at the |
@jdebacker. This PR is ready for your review. |
Looks great - thanks @rickecon! |
This PR:
rpy2>=3.5.12
inenvironment.yml
andsetup.py
. This is meant to fix the error below in installing OG-USA in another repository.rpy2
package download out of theconda-forge
channel in theenvironment.yml
file into thepip
download section.psid_data_setup.py
.wheel
package toenvironment.yml
dependencies. It was already insetup.py
.build_and_test.yml
cc: @jdebacker