How to propose more code changes in Phase3

[martinholmer]

With less than a week left in Phase3 of our project, @donboyd5 asked @martinholmer to merge PR #144 so that now the tax expenditure estimates on the master branch look plausible relative to those produced by the federal agencies.

If you want to propose additional code changes, be sure to include in your pull request a description of how your code changes affect the 2023 tax expenditure estimates. Here is how to do that:

(1) Put the tax_expenditues_master file in the top-level TMD directory (see contents below)

(2) Confirm you are using Tax-Calculator 4.1.0 (using tc --version in the top-level directory)

(3) Execute the following commands:

make flat-file  ;  TAXEXP=x pytest . -m taxexp
diff tax_microdata_benchmarking/storage/output/tax_expenditures  tax_expenditures_master

(4) Include the diff results in a comment in your pull request with an explanation of why non-trivial differences occurred with your code changes

Here are the contents of the tax_expenditues_master file after the merge of PR #151:

YR,KIND,EST= 2023 iitax 2215.0
YR,KIND,EST= 2023 ctc 132.2
YR,KIND,EST= 2023 eitc 78.6
YR,KIND,EST= 2023 social_security_partial_taxability 52.2
YR,KIND,EST= 2023 niit -52.9
YR,KIND,EST= 2023 cgqd_tax_preference 221.7
YR,KIND,EST= 2023 qbid 54.1
YR,KIND,EST= 2023 salt 20.4
YR,KIND,EST= 2026 iitax 2786.5
YR,KIND,EST= 2026 ctc 48.6
YR,KIND,EST= 2026 eitc 88.0
YR,KIND,EST= 2026 social_security_partial_taxability 70.9
YR,KIND,EST= 2026 niit -51.2
YR,KIND,EST= 2026 cgqd_tax_preference 222.0
YR,KIND,EST= 2026 qbid -0.0
YR,KIND,EST= 2026 salt 160.5

[martinholmer]

This procedure has been made obsolete by the test added by PR #155.