Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 [Patch]: Add test where enabling -Verbose in a function is not allowed #53

Merged
merged 8 commits into from
Apr 14, 2024
Merged

🩹 [Patch]: Add test where enabling -Verbose in a function is not allowed #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2d6091c
Test if verbose switch is enabled in functions
MariusStorhaug Apr 14, 2024
39c7d00
Test verbose
MariusStorhaug Apr 14, 2024
51edfff
Fix test
MariusStorhaug Apr 14, 2024
032ed35
test
MariusStorhaug Apr 14, 2024
fe5d3cc
test
MariusStorhaug Apr 14, 2024
96d25af
Fix
MariusStorhaug Apr 14, 2024
692b7fe
Test
MariusStorhaug Apr 14, 2024
05ac02a
Fix
MariusStorhaug Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions scripts/tests/PSModule/SourceCode.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ Describe 'PSModule - SourceCode tests' {

# It 'All script files have tests' {} # Look for the folder name in tests called the same as section/folder name of functions

It "Should not contain '-Verbose' unless it is disabled using ':`$false' qualifier after it" {
$issues = @('')
$scriptFiles | ForEach-Object {
Select-String -Path $_.FullName -Pattern '\s(-Verbose(?::\$true)?)\b(?!:\$false)' -AllMatches | ForEach-Object {
$issues += " - $($_.Path):L$($_.LineNumber)"
}
}
$issues -join [Environment]::NewLine |
Should -BeNullOrEmpty -Because "the script should not contain '-Verbose' unless it is disabled using ':`$false' qualifier after it."
}
}

Context 'Function/filter design' {
Expand Down
6 changes: 3 additions & 3 deletions tests/src/finally.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Write-Verbose '------------------------------' -Verbose
Write-Verbose '--- THIS IS A LAST LOADER ---' -Verbose
Write-Verbose '------------------------------' -Verbose
Write-Verbose '------------------------------'
Write-Verbose '--- THIS IS A LAST LOADER ---'
Write-Verbose '------------------------------'
6 changes: 3 additions & 3 deletions tests/src/init/initializer.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Write-Verbose '-------------------------------' -Verbose
Write-Verbose '--- THIS IS AN INITIALIZER ---' -Verbose
Write-Verbose '-------------------------------' -Verbose
Write-Verbose '-------------------------------'
Write-Verbose '--- THIS IS AN INITIALIZER ---'
Write-Verbose '-------------------------------'
6 changes: 3 additions & 3 deletions tests/src/scripts/loader.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Write-Verbose '-------------------------' -Verbose
Write-Verbose '--- THIS IS A LOADER ---' -Verbose
Write-Verbose '-------------------------' -Verbose
Write-Verbose '-------------------------'
Write-Verbose '--- THIS IS A LOADER ---'
Write-Verbose '-------------------------'
6 changes: 3 additions & 3 deletions tests/srcWithManifest/finally.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Write-Verbose '------------------------------' -Verbose
Write-Verbose '--- THIS IS A LAST LOADER ---' -Verbose
Write-Verbose '------------------------------' -Verbose
Write-Verbose '------------------------------'
Write-Verbose '--- THIS IS A LAST LOADER ---'
Write-Verbose '------------------------------'
6 changes: 3 additions & 3 deletions tests/srcWithManifest/init/initializer.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Write-Verbose '-------------------------------' -Verbose
Write-Verbose '--- THIS IS AN INITIALIZER ---' -Verbose
Write-Verbose '-------------------------------' -Verbose
Write-Verbose '-------------------------------'
Write-Verbose '--- THIS IS AN INITIALIZER ---'
Write-Verbose '-------------------------------'
6 changes: 3 additions & 3 deletions tests/srcWithManifest/scripts/loader.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Write-Verbose '-------------------------' -Verbose
Write-Verbose '--- THIS IS A LOADER ---' -Verbose
Write-Verbose '-------------------------' -Verbose
Write-Verbose '-------------------------'
Write-Verbose '--- THIS IS A LOADER ---'
Write-Verbose '-------------------------'
Loading