Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Insert make_equidistant to interpolate non-equidistant time series #38

Merged
merged 44 commits into from
Jul 15, 2019

Conversation

BjoernLudwigPTB
Copy link
Member

@BjoernLudwigPTB BjoernLudwigPTB commented Feb 20, 2019

Resolve #30 by inserting a function make_equidistant() into tools module as proposed and discussed in the according issue.

@PTB-M4D PTB-M4D deleted a comment Feb 21, 2019
@PTB-M4D PTB-M4D deleted a comment Feb 21, 2019
@PTB-M4D PTB-M4D deleted a comment Feb 21, 2019
@PTB-M4D PTB-M4D deleted a comment Feb 21, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 3, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 4, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 4, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 4, 2019
Signed-off-by: Bjoern Ludwig <bjoern.ludwig@ptb.de>
@PTB-M4D PTB-M4D deleted a comment Jul 9, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 9, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 9, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 9, 2019
@codecov-io
Copy link

codecov-io commented Jul 11, 2019

Codecov Report

Merging #38 into master will increase coverage by 1.38%.
The diff coverage is 65.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   17.04%   18.43%   +1.38%     
==========================================
  Files          16       16              
  Lines        1267     1291      +24     
  Branches      206      210       +4     
==========================================
+ Hits          216      238      +22     
- Misses       1044     1045       +1     
- Partials        7        8       +1
Impacted Files Coverage Δ
PyDynamic/misc/__init__.py 100% <100%> (ø) ⬆️
PyDynamic/uncertainty/propagate_filter.py 10% <100%> (ø) ⬆️
PyDynamic/misc/testsignals.py 46.15% <100%> (ø) ⬆️
PyDynamic/deconvolution/fit_filter.py 7.97% <100%> (ø) ⬆️
PyDynamic/misc/tools.py 37.97% <60%> (+23.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5261814...2996110. Read the comment docs.

@PTB-M4D PTB-M4D deleted a comment Jul 11, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 12, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 13, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 13, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 15, 2019
Copy link
Contributor

@mgrub mgrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We went through all the new code + tests together with @BjoernLudwigPTB and it looks very good.

@PTB-M4D PTB-M4D deleted a comment Jul 15, 2019
@scrutinizer-notifier
Copy link

The inspection completed: 3 new issues, 12 updated code elements

@PTB-M4D PTB-M4D deleted a comment Jul 15, 2019
@BjoernLudwigPTB BjoernLudwigPTB merged commit 20cd1ca into master Jul 15, 2019
@BjoernLudwigPTB
Copy link
Member Author

The interpolation with methods next, previous, nearest and linear is finished and well tested in the test suite. Cubic spline interpolation and least-squares are on the list, but will be added at a later time, as well as integrating uncertainty of timestamps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Implementation of interpolation methods for non-equidistant samples
4 participants