Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update php-cs-fixer #537

Merged
merged 3 commits into from
May 17, 2021
Merged

update php-cs-fixer #537

merged 3 commits into from
May 17, 2021

Conversation

garak
Copy link
Member

@garak garak commented May 15, 2021

No description provided.

@garak garak requested a review from JellyBellyDev May 15, 2021 16:00
@JellyBellyDev
Copy link
Member

why did the CI break?

@garak
Copy link
Member Author

garak commented May 17, 2021

why did the CI break?

Because php-cs-fixer changed occurrences of \Exception to Exception :-(

@JellyBellyDev
Copy link
Member

why did the CI break?

Because php-cs-fixer changed occurrences of \Exception to Exception :-(

without add the use on top? ;(

@garak
Copy link
Member Author

garak commented May 17, 2021

Found related issue: PHP-CS-Fixer/PHP-CS-Fixer#5684

JellyBellyDev
JellyBellyDev approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@JellyBellyDev JellyBellyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JellyBellyDev JellyBellyDev merged commit 2071489 into master May 17, 2021
@JellyBellyDev JellyBellyDev deleted the update-fixer branch May 17, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JellyBellyDev JellyBellyDev JellyBellyDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garak @JellyBellyDev