Added style parameter #707
Conversation
JellyBellyDev
requested review from
garak,
JellyBellyDev and
AlessandroMinoccheri
|
@ricardoboss thanks so much for your PR! What do you think to add also the specific section on the landing page to explain the new feature? |
|
Sounds reasonable. I will add some documentation to this PR. |
|
@JellyBellyDev I need some help adding the |
| // } | ||
|
|
||
| var_dump($style); | ||
| die; |
There was a problem hiding this comment.
This is for testing. I am not getting the actual style parameter I put in the URL. It does not work yet! Can you help?
There was a problem hiding this comment.
after making the change, restart docker-compose, sometimes the changes are not applied in the container :S
There was a problem hiding this comment.
Already did. I am not too familiar with Symfony yet, maybe I just made a stupid mistake somewhere.
There was a problem hiding this comment.
as soon as I have a second I throw an eye too ;)
There was a problem hiding this comment.
I fixed your problem! Can i commit on this branch?
There was a problem hiding this comment.
I add my commit here: #733
| {% endfor %} | ||
| </div> | ||
| </div> | ||
| </section> |
There was a problem hiding this comment.
can you put a screenshot please! :)
There was a problem hiding this comment.
Will do once I get the correct badges rendered :)
There was a problem hiding this comment.
First the flat variants, then plastic and for-the-badge. Speaking of, can you update PUGX/poser to also include the fourth style, please? :D
There was a problem hiding this comment.
I tried to do composer update package but I've a error! :S
There was a problem hiding this comment.
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires badges/poser ^2.3 -> satisfiable by badges/poser[v2.3.0].
- badges/poser v2.3.0 requires kartsims/easysvg ^2.0 -> found kartsims/easysvg[dev-master, 1.0] but it does not match the constraint.
There was a problem hiding this comment.
We need to add my fork as a repository as well, it seems...
"repositories": [
{
"type": "vcs",
"url": "https://github.com/ricardoboss/easysvg"
}
],
|
Hi @ricardoboss, |
|
@JellyBellyDev done |
|
@ricardoboss shouldn't I also notice a diff to composer.lock? |
|
No, because I haven't updated the PUGX/poser package yet. |
|
@JellyBellyDev do you want me to close this PR in favor of #733? |
|
Yea! Thanks! in doing so we can work together! ;) |
This PR will partially fix #705.
Why partially? Because badges/poser doesn't support the fourth requested style:
for-the-badge. There is already an issue for this: badges/poser#55. I will try and implement this over there as well.