Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle custom flight tasks? #10235

Closed
ChristophTobler opened this issue Aug 15, 2018 · 5 comments
Closed

How to handle custom flight tasks? #10235

ChristophTobler opened this issue Aug 15, 2018 · 5 comments

Comments

@ChristophTobler
Copy link
Contributor

ChristophTobler commented Aug 15, 2018

There should be a possibility to add a custom flight task (and launch it) without much effort or creating a large diff and conflicts.

Our long term goal is to move the logic if a task can run/be activated to the actual flight task because we think the current situation with commander knowing everything doesn't scale.

Approaches

@dagar
Copy link
Member

dagar commented Aug 15, 2018

One idea was to leave room in the state machine for custom classes of nav state.

  • custom fully autonomous
  • custom manual modes with full position control
  • etc

These buckets would allow you to do anything you want within with the same control mode flags, but ensure consistent failsafe handling.

#10237 is a good example of why this decentralized handling is potentially a bad idea. We need to have this logic handled by well defined state machines, but that doesn't mean all within commander.

@dagar
Copy link
Member

dagar commented Aug 15, 2018

Conveying the mode to the ground is another problem.

@ChristophTobler
Copy link
Contributor Author

One idea was to leave room in the state machine for custom classes of nav state.

Could be a short term option

#10237 is a good example of why this decentralized handling is potentially a bad idea. We need to have this logic handled by well defined state machines, but that doesn't mean all within commander.

I think the current situation is a good example of why the commander should not have everything predefined.
Yes, there needs to be a centralized handling of tasks and fail-safes but with feedback from the respective tasks and not hard-coded into a state machine.

@stale
Copy link

stale bot commented Feb 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Admin: Wont fix label Feb 4, 2019
@stale
Copy link

stale bot commented Feb 18, 2019

Closing as stale.

@stale stale bot closed this as completed Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants