Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airframe config for px4vision devkit drone #13683

Merged
merged 2 commits into from Dec 16, 2019
Merged

Conversation

Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented Dec 5, 2019

This adds a airframe config for the px4vision devkit drone produced by Holybro

Would it be possible to get this in for the 1.10 release?

dagar
dagar previously approved these changes Dec 9, 2019
param set THR_MDL_FAC 0.3
fi

pmw3901 start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use SENS_EN_PMW3901 instead of starting it manually?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagar Done

@RomanBapst
Copy link
Contributor

@dagar @Jaeyoung-Lim I fixed this branch up and squashed the commits, please have a look.

bkueng
bkueng previously approved these changes Dec 13, 2019
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flash overflow, can you remove it from v2?

kamilritz and others added 2 commits December 13, 2019 11:01
Update high level tuning params on px4vision

Update collision preventer parameter naming

Add TELEM1 configurations to airframe configs

px4vision airframe: fmu, oneshot, tuning, revert some to default

addressed review comments

Signed-off-by: RomanBapst <bapstroman@gmail.com>
Signed-off-by: RomanBapst <bapstroman@gmail.com>
@bkueng bkueng merged commit 4bcdf56 into master Dec 16, 2019
@bkueng bkueng deleted the pr-pixhawkvision-config branch December 16, 2019 07:21
then
# System parameters
# use FMU motor outputs for less delay in the rate control loop
param set SYS_USE_IO 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the parameter is using FMU PWM is instead of IO PWM here, but holybro is still using IO PWM on shipping verision now. Looks they have an old customized version. I think we should notify Holybro and early adopters.

param set MPC_XY_VEL_P 0.079
param set MPC_XY_TRAJ_P 0.3
param set MPC_Z_TRAJ_P 0.3
param set MPC_Z_VEL_I 0.15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MPC_Z_VEL_I max value is 0.1

param set MPC_ACC_DOWN_MAX 5
param set MPC_ACC_HOR_MAX 10
param set MPC_ACC_UP_MAX 4
param set MPC_MANTHR_MIN 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set manual throttle MPC_MANTHR_MIN to 0%? Why? Will this cause unsafety?

param set MPC_VEL_MANUAL 5
param set MPC_XY_CRUISE 5
param set MPC_XY_VEL_MAX 5
param set MPC_XY_VEL_P 0.079
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MPC_XY_VEL_P only support %.2f

param set MPC_XY_VEL_MAX 5
param set MPC_XY_VEL_P 0.079
param set MPC_XY_TRAJ_P 0.3
param set MPC_Z_TRAJ_P 0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This MPC_Z_TRAJ_P parameter is not exist now.
Related PR: #13596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants