ADC: replace ioctl with uorb message #14087

SalimTerryLi · 2020-02-03T06:31:33Z

This is spitted from #13833 .

This PR focus on replace ioctls with uORB message. Some existing modules/drivers are affected.

SalimTerryLi · 2020-02-03T06:58:48Z

Device ID is set but not used. All logic kept same as before. This should be safe to merge.

SalimTerryLi · 2020-02-03T07:09:31Z

There are two things to be checked:

whether old ioctl message manages channel_id field correctly? I mean that adc_msg[A].am_channel == A should be true if that channel is valid.
Do all boards have the same 3v3 ADC vref? If not, there should be some macro defined cases in ADC.cpp.

Confirmed. There is no problem.

bkueng

Good rework, thanks.
What is the testing you have done?

src/drivers/adc/ADC.cpp

src/modules/battery_status/analog_battery.cpp

src/drivers/rc_input/RCInput.cpp

src/modules/battery_status/battery_status.cpp

msg/adc_report.msg

src/modules/battery_status/battery_status.cpp

SalimTerryLi · 2020-02-08T08:19:09Z

This is the last reference to that parameter. But I cannot find anything in the code which provides ADC specification such as sample precision and voltage reference. 0.0008 mostly indicate that the board is using 3v3 as vref with 2^12 bits precision but I cannot find anything related in code.
@bkueng Sorry but I'm unfamiliar with these devices. Any help is welcome.

SalimTerryLi · 2020-02-08T08:52:04Z

Good rework, thanks.
What is the testing you have done?

Currently I have no hardware to test. This pr is diverged from a previous one so my test code on my platform could not be uploaded. If needed, I could commit them temporarily and then revert them for a clean PR.

bkueng · 2020-02-10T08:03:12Z

This is the last reference to that parameter. But I cannot find anything in the code which provides ADC specification such as sample precision and voltage reference. 0.0008 mostly indicate that the board is using 3v3 as vref with 2^12 bits precision but I cannot find anything related in code.
@bkueng Sorry but I'm unfamiliar with these devices. Any help is welcome.

They should not have been added to that board, you can just remove them from there (the default should be used).

SalimTerryLi · 2020-02-10T08:10:36Z

This is the last reference to that parameter. But I cannot find anything in the code which provides ADC specification such as sample precision and voltage reference. 0.0008 mostly indicate that the board is using 3v3 as vref with 2^12 bits precision but I cannot find anything related in code.
@bkueng Sorry but I'm unfamiliar with these devices. Any help is welcome.

They should not have been added to that board, you can just remove them from there (the default should be used).

Acknowledged. I'm contacting dagar to get ADC reference voltage properly provided for each board.

src/drivers/adc/ADC.cpp

src/drivers/rc_input/RCInput.cpp

SalimTerryLi · 2020-02-22T07:59:25Z

Solved conflict with master 4c1adc0
Probably caused by in-formatted white spaces that make format doesn't deal with.

SalimTerryLi · 2020-02-22T08:33:07Z

It's ready. @dagar
If someone could provide a test on the real hardware to prove its correctness would be better. Sorry for that I do not have any device to do such a test. If analog battery is monitored correctly, then this is safe to merge.

src/drivers/adc/ADC.cpp

src/drivers/rc_input/RCInput.cpp

1. remove cdev implement and use uORB publication 2. publish all channels instead of only battery voltage moniting channel 3. correct vref to 3.0f 4. temporarily disable test function

This would imporve the performance

Critical bug fix 1 Co-Authored-By: David Sidrane <David.Sidrane@Nscdg.com>

Critical bug fix 2 Co-Authored-By: David Sidrane <David.Sidrane@Nscdg.com>

Co-Authored-By: Beat Küng <beat-kueng@gmx.net>

Critical bug fix Co-Authored-By: Beat Küng <beat-kueng@gmx.net>

analog differential pressure sensor reads from uORB(sensors.cpp)

SalimTerryLi force-pushed the pr-adc_replace_ioctl_with_uorb-improve branch from 371ed98 to c6f9b61 Compare February 3, 2020 06:56

SalimTerryLi requested a review from dagar February 3, 2020 06:56

SalimTerryLi marked this pull request as ready for review February 3, 2020 07:16

SalimTerryLi force-pushed the pr-adc_replace_ioctl_with_uorb-improve branch from c6f9b61 to 1c9451e Compare February 6, 2020 05:12

bkueng reviewed Feb 7, 2020

View reviewed changes

SalimTerryLi force-pushed the pr-adc_replace_ioctl_with_uorb-improve branch from 1126845 to b445912 Compare February 7, 2020 15:44

SalimTerryLi force-pushed the pr-adc_replace_ioctl_with_uorb-improve branch from 9807abc to 9188c4a Compare February 7, 2020 17:43

weekly-digest bot mentioned this pull request Feb 9, 2020

Weekly Digest (2 February, 2020 - 9 February, 2020) #14124

Closed

SalimTerryLi mentioned this pull request Feb 10, 2020

ADC driver report back vref alone with sample count #14136

Merged

weekly-digest bot mentioned this pull request Feb 16, 2020

Weekly Digest (9 February, 2020 - 16 February, 2020) #14167

Closed

davids5 reviewed Feb 21, 2020

View reviewed changes

src/drivers/adc/ADC.cpp Outdated Show resolved Hide resolved

src/drivers/rc_input/RCInput.cpp Show resolved Hide resolved

SalimTerryLi force-pushed the pr-adc_replace_ioctl_with_uorb-improve branch from 88e63e3 to a14a1d0 Compare February 21, 2020 15:52

SalimTerryLi force-pushed the pr-adc_replace_ioctl_with_uorb-improve branch from f6eae80 to da0a336 Compare February 22, 2020 07:58

SalimTerryLi force-pushed the pr-adc_replace_ioctl_with_uorb-improve branch 3 times, most recently from c4d7c6b to 882acd8 Compare February 22, 2020 08:13

davids5 reviewed Feb 22, 2020

View reviewed changes

src/drivers/adc/ADC.cpp Outdated Show resolved Hide resolved

src/drivers/rc_input/RCInput.cpp Show resolved Hide resolved

weekly-digest bot mentioned this pull request Feb 23, 2020

Weekly Digest (16 February, 2020 - 23 February, 2020) #14213

Closed

SalimTerryLi and others added 20 commits March 20, 2020 17:09

purge BOARD_ADC_POS_REF_V_FOR_*_CHAN

735dceb

update AEROFC_ADC

33692e0

1. remove cdev implement and use uORB publication 2. publish all channels instead of only battery voltage moniting channel 3. correct vref to 3.0f 4. temporarily disable test function

remove comments.

d17e94f

Fix logic on batt assignment: PX4#14087 (comment)

894900a

This would imporve the performance

force fill unused channel id to -1

20fa835

Update src/modules/battery_status/battery_status.cpp

7945a5e

Critical bug fix 1 Co-Authored-By: David Sidrane <David.Sidrane@Nscdg.com>

Update src/modules/battery_status/battery_status.cpp

cc473d9

Critical bug fix 2 Co-Authored-By: David Sidrane <David.Sidrane@Nscdg.com>

fix param update: i_channel

7e15d73

remove unused declaration

eacf403

Update msg/adc_report.msg

806f6c2

Co-Authored-By: Beat Küng <beat-kueng@gmx.net>

Update src/drivers/rc_input/RCInput.cpp

38318bf

Critical bug fix Co-Authored-By: Beat Küng <beat-kueng@gmx.net>

update bbblue parameter set in the startup script

e968c1a

auto-generated value of PX4_MAX_ADC_CHANNELS (run time)

cd98e4a

remove const_cast

95da375

make adc and jig voltages tests from systemcmds/tests using adc_report

a40966d

introduce ADC_DP_V_DIV

50e8f60

analog differential pressure sensor reads from uORB(sensors.cpp)

using arraySize()

0531c8a

remove comments

a4ab180

cleanup _adc_fd in sensors.cpp

e404591

purge CDev implementation of drivers/adc

b431f72

SalimTerryLi force-pushed the pr-adc_replace_ioctl_with_uorb-improve branch from ba94c6a to b431f72 Compare March 20, 2020 09:17

SalimTerryLi added 4 commits March 20, 2020 17:23

AEROFC_ADC using identical CDev path

4445319

purge ADC0_DEVICE_PATH

f9efbf9

minimize delay value before report available

00365a5

bug fix: Jenkins Compile MacOS

a15c0f6

SalimTerryLi requested a review from bkueng March 20, 2020 09:40

bkueng approved these changes Mar 20, 2020

View reviewed changes

bkueng merged commit dc8e775 into PX4:master Mar 20, 2020

Test Flights automation moved this from Ready for testing to Done Mar 20, 2020

SalimTerryLi deleted the pr-adc_replace_ioctl_with_uorb-improve branch April 24, 2023 06:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADC: replace ioctl with uorb message #14087

ADC: replace ioctl with uorb message #14087

SalimTerryLi commented Feb 3, 2020

SalimTerryLi commented Feb 3, 2020 •

edited

SalimTerryLi commented Feb 3, 2020 •

edited

bkueng left a comment

SalimTerryLi commented Feb 8, 2020 •

edited

SalimTerryLi commented Feb 8, 2020

bkueng commented Feb 10, 2020

SalimTerryLi commented Feb 10, 2020

SalimTerryLi commented Feb 22, 2020 •

edited

SalimTerryLi commented Feb 22, 2020

ADC: replace ioctl with uorb message #14087

ADC: replace ioctl with uorb message #14087

Conversation

SalimTerryLi commented Feb 3, 2020

SalimTerryLi commented Feb 3, 2020 • edited

SalimTerryLi commented Feb 3, 2020 • edited

bkueng left a comment

Choose a reason for hiding this comment

SalimTerryLi commented Feb 8, 2020 • edited

SalimTerryLi commented Feb 8, 2020

bkueng commented Feb 10, 2020

SalimTerryLi commented Feb 10, 2020

SalimTerryLi commented Feb 22, 2020 • edited

SalimTerryLi commented Feb 22, 2020

SalimTerryLi commented Feb 3, 2020 •

edited

SalimTerryLi commented Feb 3, 2020 •

edited

SalimTerryLi commented Feb 8, 2020 •

edited

SalimTerryLi commented Feb 22, 2020 •

edited