Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AUAV X2.1 Board Config for 20608 #6569

Closed
wants to merge 2 commits into from
Closed

Fix AUAV X2.1 Board Config for 20608 #6569

wants to merge 2 commits into from

Conversation

pkocmoud
Copy link
Contributor

These changes were required to fix support for the ICM-20608 after this commit:

f746141

This has been tested!

Copy link
Contributor

@kd0aij kd0aij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on X2.1; both 9250 and 20608 look OK

@kd0aij
Copy link
Contributor

kd0aij commented Feb 13, 2017

@davids5 looks like there's something wrong with unrelated commit c685cdb

@davids5
Copy link
Member

davids5 commented Feb 13, 2017

@pkocmoud - will this HW only ship with the 20608 in that U location? - if not we should add the
#define PX4_SPIDEV_ICM_20602 and place it on the same case label as PX4_SPIDEV_ICM_20608

@pkocmoud
Copy link
Contributor Author

I am sure this will follow the Pixracer and get the 20602 soon.

@pkocmoud
Copy link
Contributor Author

@LorenzMeier This has been tested and is ready to merge once CI testing completes.

@LorenzMeier
Copy link
Member

Code style failure on whitespace: https://travis-ci.org/PX4/Firmware/jobs/202111408

Phillip Kocmoud added 2 commits February 16, 2017 09:59
These changes were required to fix support for the ICM-20608 after this commit:

f746141

This has been tested!
@LorenzMeier
Copy link
Member

It had still formatting issues, but I fixed them now for you and rebased and applied.

@pkocmoud pkocmoud deleted the x2.1fix branch February 17, 2017 11:58
@coveralls
Copy link

Coverage Status

Coverage increased (+32.06%) to 49.86% when pulling fd4d16e on pkocmoud:x2.1fix into 7bd8514 on PX4:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants