aerofc: Add and use a new I2C bus #7070
Conversation
| CONFIG_STM32_UART7_SERIALDRIVER=y | ||
| # CONFIG_STM32_UART7_1WIREDRIVER is not set | ||
| # CONFIG_UART7_RS485 is not set | ||
| CONFIG_UART7_RXDMA=y |
There was a problem hiding this comment.
did you check the dma channel does not conflict with other channels?
There was a problem hiding this comment.
check now, UART7 is the only user of his DMA stream.
src/drivers/ist8310/ist8310.cpp
Outdated
| @@ -1279,6 +1280,9 @@ struct ist8310_bus_option { | |||
| #ifdef PX4_I2C_BUS_ONBOARD | |||
| { IST8310_BUS_I2C_INTERNAL, "/dev/ist8310_int", PX4_I2C_BUS_ONBOARD, NULL }, | |||
| #endif | |||
| #ifdef PX4_I2C_BUS_EXPANSION2 | |||
| { IST8310_BUS_I2C_EXTERNAL2, "/dev/inst8310_ext", PX4_I2C_BUS_EXPANSION2, NULL }, | |||
There was a problem hiding this comment.
typo: should be ist8310_ext... what if you have both connected? It should probably be ist8310_ext2 otherwise would conflict.
There was a problem hiding this comment.
Oh thanks, ok I will rename to ext2.
|
Overall LGTM. Some minor comments above. |
zehortigoza
force-pushed
the
additional_i2c_bus
branch
from
9d46694
to
e2d9a7d
Compare
|
Please merge when all things are ready including the FPGA image for a complete upgrade. |
src/drivers/ist8310/ist8310.cpp
Outdated
| @@ -1279,6 +1280,9 @@ struct ist8310_bus_option { | |||
| #ifdef PX4_I2C_BUS_ONBOARD | |||
| { IST8310_BUS_I2C_INTERNAL, "/dev/ist8310_int", PX4_I2C_BUS_ONBOARD, NULL }, | |||
| #endif | |||
| #ifdef PX4_I2C_BUS_EXPANSION2 | |||
| { IST8310_BUS_I2C_EXTERNAL2, "/dev/ist8310_ext2", PX4_I2C_BUS_EXPANSION2, NULL }, | |||
There was a problem hiding this comment.
this should stay on the current PX4_I2C_BUS_EXPANSION
|
Note that we will need this in for the v1.6 release. Do you have the FPGA image and a BSP update ready? |
|
This shouldn't be in 1.6 yet. The latest release of the BSP doesn't contain the needed changes. |
|
Btw last BSP is 1.3.1: https://github.com/intel-aero/meta-intel-aero/releases Should be available for download next Monday. |
zehortigoza
force-pushed
the
additional_i2c_bus
branch
from
e2d9a7d
to
c1ff32b
Compare
zehortigoza
force-pushed
the
additional_i2c_bus
branch
from
c1ff32b
to
d16cdd4
Compare
|
@lucasdemarchi now should be a good time to get back to this? I just rebased and tested this |
|
Yes. And remember to leave the current i2c bus as is |
zehortigoza
force-pushed
the
additional_i2c_bus
branch
from
d16cdd4
to
730467b
Compare
It was already fixed. |
zehortigoza
force-pushed
the
additional_i2c_bus
branch
3 times, most recently
from
fc1a8c1
to
4f1b07a
Compare
The UART3 also have the I2C bus 2 functions so moving GPS to UART7 to have one additional I2C. To keep GPS working is also necessary update the FPGA RTL to version 0xC1 or higher.
Nothing use this define right now so lets remove it. Several other boards also have this defines that can also be removed.
Now that UART3 is no longer in use we can use this I2C bus.
This change plus the new FPGA RTL(version 0xC1 or higher) will make use of the new I2C bus, this new bus will be shared between aerofc_adc and ll40ls(if connected) and leaving the old bus just to IST8310.
zehortigoza
force-pushed
the
additional_i2c_bus
branch
from
4f1b07a
to
42a8950
Compare
|
FPGA firmware updated and binary sent to be integrated on Aero image. |
|
@zehortigoza Could you explain how this should be merged? If we merge now, does master work with the latest Aero BSP or where should we point users? |
|
@LorenzMeier PX4 will boot and run ok with the FPGA firmware from the latest Aero BSP release(1.4v) but the user will lose GPS. Users can download the updated FPGA firmware before the release from here: https://github.com/intel-aero/meta-intel-aero/tree/master/recipes-support/jam-stapl/jam-stapl |
|
@LorenzMeier I don't have powers in this repo to merge this. Can you do so, please? |
|
Sorry for the oversight - and we can certainly talk about a more central role in the maintenance team. It would be good to have you being able to do more. |
To this work is necessary also update the FPGA RTL(intel-aero/intel-aero-fpga#2)