cmake: AeroFC: Remove unused apps and libs #7993
Conversation
|
Is your real intention to remove LPE? So far it is very useful for people working with mocap or with VIO, like my case. If you can, please spare LPE on it :) |
|
topic_listener is huge and only useful for debugging with a console connected. |
We are running out of flash space in AeroFC so a cleanup is necessary. Tools not used in Aero RTF, INAV, fixed wing control, vtol control and unused libs was removed. before $ size build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx text data bss dec hex filename 956880 3524 14608 975012 ee0a4 firmware_nuttx after $ size build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx text data bss dec hex filename 832200 3508 14616 850324 cf994 build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx
|
@dagar Thanks for the tip. @TSC21 ok, for now we have space for both when removing topic listener old PR old PR - topic listener old PR - topic listener + lpe |
zehortigoza
force-pushed
the
cleanup
branch
from
0463a0b
to
850f6a8
Compare
|
That's probably all you can do for now. In the not too distant future we hope to be able to drastically reduce the code in the drivers. A surprisingly large portion of it is duplicated boilerplate. |
|
Does the aero actually use anything in the px4fmu module? |
|
@dagar it use px4fmu to handle RC. |
|
RC input only? Is the only output handled through tap_esc? I have a branch that splits RC input and safety button handling out of px4fmu. I'll test and open a PR soon. |
|
@dagar exacly. nice let me know when you open this PR so I can test it in AeroFC. Thanks |
|
@zehortigoza yet another thing we could do is limit the airframe selection. |
We are running out of flash space in AeroFC so a cleanup is necessary.
Tools not used in Aero RTF, LPE, fixed wing control, vtol control and
unused libs was removed.
before
$ size firmware_nuttx
text data bss dec hex filename
956880 3524 14608 975012 ee0a4 firmware_nuttx
after
$ size firmware_nuttx
text data bss dec hex filename
835560 3508 14616 853684 d06b4 firmware_nuttx