Fix follow me position setpoint #8203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `mission_item_to_position_setpoint()` is called in `FollowTarget::update_position_sp()`. The nav_cmd is a NAV_CMD_DO_FOLLOW_REPOSITION as set earlier in `set_follow_target_item`. Since `mission_item_to_position_setpointi` returns early because the item presumably contains no position, the lat/lon of the mission_item are not copied over to the position_setpoint and therefore the vehicle will never move in follow me position mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
mission_item_to_position_setpoint()is called inFollowTarget::update_position_sp(). The nav_cmd is aNAV_CMD_DO_FOLLOW_REPOSITIONas set earlier inset_follow_target_item.Since
mission_item_to_position_setpointreturns early because the itempresumably contains no position, the lat/lon of the mission_item are
not copied over to the position_setpoint and therefore the vehicle will
never move in follow me position mode.
This PR fixes this problem and should unblock the DroneCore follow me implementation.