Adds ability for generate_listener.py to process out-of-tree uORB message definitions as well #9097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage definitions as well
dagar
approved these changes
Mar 16, 2018
|
Looks right, however I'd strongly recommend adding something basic to the CI system that tests the various EXTERNAL module pieces. Otherwise it's very easy to unintentionally break. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to PR #9073.
@mhkabir @bkueng : I didn't realise that
generate_listener.pywas using the original message definition files and not the generated uORB topic headers in order to generate topic_listener.cpp.topic_listener.cpp will now be generated with the out-of-tree uORB message definitions as well.