BUGFIX hardfault FMUv5 List was used before being initialized. #9652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 12, 2018
_uavcan_open_request_list was accessed before it was initalized.
|
Awesome! |
|
@davids5 Can you rebase this on master? |
davids5
force-pushed
the
master_fmuv5_uavcan_hardfault
branch
from
e295f71
to
90cd33e
Compare
|
@LorenzMeier - rebased. For the record the bug has been in the code forever. It was not a race. The dereferencing null on the F4 did not pitch the exception but does on the F7. |
LorenzMeier
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_uavcan_open_request_list was accessed before it was initalized.
Fixes #9648