New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmu fix MAIN/AUX parameters #9925

Merged
merged 3 commits into from Jul 17, 2018

Conversation

Projects
None yet
2 participants
@dagar
Copy link
Member

dagar commented Jul 16, 2018

@dagar dagar requested review from bkueng and LorenzMeier Jul 16, 2018

@dagar

This comment has been minimized.

Copy link
Member Author

dagar commented Jul 16, 2018

Sensors isn't the right owner for PWM parameters, but it's fine for now.
The single parameter file pwm_params.c was split into 2 files (MAIN and AUX) and used to centralize all PWM parameters. I also added AUX 7&8.

@dagar

This comment has been minimized.

Copy link
Member Author

dagar commented Jul 16, 2018

image

Unfortunately all 8 PWM disarmed parameters are still set active as a result of the init script.

@dagar

This comment has been minimized.

Copy link
Member Author

dagar commented Jul 16, 2018

@mcsauder this reminds me that we could cleanup a good portion of the init script PWM_* variable mess by using parameters directly.

@dagar dagar added the bug label Jul 16, 2018

@bkueng
Copy link
Member

bkueng left a comment

One suggestion, otherwise looks good

@@ -928,13 +922,23 @@ PX4FMU::update_pwm_rev_mask()

for (unsigned i = 0; i < _max_actuators; i++) {
char pname[16];
int32_t ival;

if (_class_instance == CLASS_DEVICE_PRIMARY) {

This comment has been minimized.

@bkueng

bkueng Jul 17, 2018

Member

Move this out of the loop, and use const char* pname_format = "PWM_MAIN_REV%d"?

This comment has been minimized.

@dagar

dagar Jul 17, 2018

Author Member

Done

dagar added some commits Jul 16, 2018

@dagar dagar force-pushed the pr-fmu_params branch from ce001be to a195f19 Jul 17, 2018

@dagar dagar merged commit 8985403 into master Jul 17, 2018

2 checks passed

WIP ready for review
Details
continuous-integration/jenkins/branch This commit looks good
Details

@dagar dagar deleted the pr-fmu_params branch Jul 17, 2018

@dagar dagar added this to the Release v1.8.1 milestone Jul 27, 2018

@dagar dagar referenced this pull request Jul 27, 2018

Closed

PX4 Stable v1.8.1 Planning #10064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment