[BACKPORT] UART ioctl's #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to invert and swap RX/TX on STM32F7 UARTs. I added the TIOCGINVERT as well to reserve the IOCTL number, but did not implement it. This is the same as for TIOCGSINGLEWIRE.
…equest #930)
serial: add TIOCSINVERT and TIOCSSWAP ioctl's for stm32{l4,h7} and imxrt
* stm32l4 serial: add TIOCSINVERT and TIOCSSWAP ioctl's
* stm32l4 serial: ensure TIOCSSINGLEWIRE is atomic and UE disabled
* stm32h7 serial: add TIOCSINVERT and TIOCSSWAP ioctl's
* imxrt serial: add TIOCSINVERT ioctl
Approved-by: Gregory Nutt <gnutt@nuttx.org>
|
Great, this looks much cleaner. Given the timing of an imminent PX4/Firmware NuttX minor bump (7.28 -> 7.29 PX4/PX4-Autopilot#12344) how about merging into If testing hits any issues that drag it out beyond this week we can reconsider. |
Yes that's fine with me. We can also apply it to both branches, since it's not doing anything w/o corresponding FW changes, and then pull into whichever comes first. |
|
Yes both is fine, I just didn't want it to get lost in the submodule change. |
dagar
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the
TIOCSINVERTandTIOCSSWAPUART ioctl's from NuttX master.It allows us to handle the RC port in a cleaner way with less board-specific code and configurable RC port.