Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing airframe image for quadrotor-asymmetric #10898

Open
hamishwillee opened this issue Nov 22, 2018 · 2 comments
Open

Missing airframe image for quadrotor-asymmetric #10898

hamishwillee opened this issue Nov 22, 2018 · 2 comments

Comments

@hamishwillee
Copy link
Contributor

hamishwillee commented Nov 22, 2018

See https://docs.px4.io/en/airframes/airframe_reference.html#quadrotor-asymmetric

This is using the default image. It should have its own image. @bkueng - can you help?

@stale
Copy link

stale bot commented Oct 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Oct 13, 2019
@junwoo091400
Copy link
Contributor

The "Quadrotor Asymmetric" frame doesn't seem to be processed/exist:

def GetImageName(self):
"""
Get parameter group image base name (w/o extension)
"""
if (self.type == "Standard Plane"):
return "Plane"
elif (self.type == "Flying Wing"):
return "FlyingWing"
elif (self.type == "Quadrotor x"):
return "QuadRotorX"
elif (self.type == "Quadrotor +"):
return "QuadRotorPlus"
elif (self.type == "Hexarotor x"):
return "HexaRotorX"
elif (self.type == "Hexarotor +"):
return "HexaRotorPlus"
elif (self.type == "Octorotor +"):
return "OctoRotorPlus"
elif (self.type == "Octorotor x"):
return "OctoRotorX"
elif (self.type == "Octorotor Coaxial"):
return "OctoRotorXCoaxial"
elif (self.type == "Octo Coax Wide"):
return "OctoRotorXCoaxial"
elif (self.type == "Quadrotor Wide"):
return "QuadRotorWide"
elif (self.type == "Quadrotor H"):
return "QuadRotorH"
elif (self.type == "Dodecarotor cox"):
return "DodecaRotorXCoaxial"
elif (self.type == "Simulation"):
return "AirframeSimulation"
elif (self.type == "Plane A-Tail"):
return "PlaneATail"
elif (self.type == "Plane V-Tail"):
return "PlaneVTail"
elif (self.type == "VTOL Duo Tailsitter"):
return "VTOLDuoRotorTailSitter"
elif (self.type == "Standard VTOL"):
return "VTOLPlane"
elif (self.type == "VTOL Quad Tailsitter"):
return "VTOLQuadRotorTailSitter"
elif (self.type == "VTOL Tiltrotor"):
return "VTOLTiltRotor"
elif (self.type == "VTOL Octoplane"):
return "VTOLPlaneOcto"
elif (self.type == "Coaxial Helicopter"):
return "HelicopterCoaxial"
elif (self.type == "Helicopter"):
return "Helicopter"
elif (self.type == "Hexarotor Coaxial"):
return "Y6B"
elif (self.type == "Y6A"):
return "Y6A"
elif (self.type == "Tricopter Y-"):
return "YMinus"
elif (self.type == "Tricopter Y+"):
return "YPlus"
elif (self.type == "Autogyro"):
return "Autogyro"
elif (self.type == "Airship"):
return "Airship"
elif (self.type == "Rover"):
return "Rover"
elif (self.type == "Boat"):
return "Boat"
elif (self.type == "Balloon"):
return "Balloon"
elif (self.type == "Vectored 6 DOF UUV"):
return "Vectored6DofUUV"
return "AirframeUnknown"

And it doesn't exist as an airframe either: https://github.com/PX4/PX4-Autopilot/search?q=Quadrotor+asymmetric

One frame was added in this type in this commit: 8962eaa

But was eventually removed: f454dce

We could try adding the Asymmetric image, but there is no use case for now, FYI

@stale stale bot removed the stale label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@bkueng @julianoes @hamishwillee @junwoo091400 and others