Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing compilation on eigen test #2419

Closed
TSC21 opened this issue Jun 18, 2015 · 3 comments
Closed

Failing compilation on eigen test #2419

TSC21 opened this issue Jun 18, 2015 · 3 comments

Comments

@TSC21
Copy link
Member

TSC21 commented Jun 18, 2015

I updated eigen lib to latest version: Subproject commit 9aed5e67812dd449ddea40749e65331813360fde. Now I'm getting the following when compiling:

In file included from /home/nuno/dev_px4/landing_target_support/Firmware/src/lib/eigen/Eigen/Core:296:0,
                 from /home/nuno/dev_px4/landing_target_support/Firmware/src/lib/px4_eigen.h:49,
                 from /home/nuno/dev_px4/landing_target_support/Firmware/src/systemcmds/tests/test_eigen.cpp:41:
/home/nuno/dev_px4/landing_target_support/Firmware/src/lib/eigen/Eigen/src/Core/Matrix.h:11:0: error: unterminated #ifndef
 #ifndef EIGEN_MATRIX_H
 ^
compilation terminated due to -Wfatal-errors.
@LorenzMeier
Copy link
Member

An upgrade and fix would be appreciated, I just want to set expectations right for the time budget we have available for this currently.

If you update Eigen its within your responsibility to fix any update breakage - is there a specific reason to upgrade the version? We can only allocate bandwidth for bugfixes on Eigen right now, and we will do an Eigen upgrade when needed for the general development - which, unless you have new information, is not now.

@TSC21
Copy link
Member Author

TSC21 commented Jun 20, 2015

I will take a look on this. It just updated cause I issued that all submodules got updated to latest commit, when I was just looking for updating only mavlink. But then we don't loose anything updating the modules, so I'll see what's the problem.

@TSC21
Copy link
Member Author

TSC21 commented Jun 22, 2015

It was a merging problem. Closing now

@TSC21 TSC21 closed this as completed Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants