Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flarm linux #12726

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Flarm linux #12726

wants to merge 28 commits into from

Conversation

Lafon2
Copy link

@Lafon2 Lafon2 commented Aug 17, 2019

Abgabestand der Bachelor Thesis: Erweiterung eines UAVs mit FLARM
Neue check_traffic_conus Funktion eingefügt, die basierend auf dem Collision Conus Approach die Kollisionsdetektion durchführt und ein Vehicle Command veröffentlicht.
Dieses Command wird vom Commander ignoriert und vom Navigator (ca Zeile 215) bearbeitet.
Es soll das Ausweichmanöver durchführen, indem die Setpoints_tripple überschrieben werden.
Dies funktioniert aber noch nicht korrekt.
Dieses Ausweichmanöver kann mit der Nr. 10 ausgewählt werden.

@julianoes
Copy link
Contributor

julianoes commented Aug 19, 2019

Thanks for the PR.

This community usually communicates in English. Any chance you could change the description to English?

A couple of high level notes on your changes:

  • You change the examples for your use case. The examples are supposed to be examples, so you would have to create a copy for your module/use case.
  • Also, you edited a few files with unnecessary (e.g. style) changes without changing functionality. Please check the diff.
  • To pass through the style check you need to run make format.
  • You say something doesn't work as it should yet. We can only consider this PR if everything that is implemented actually works and there are tests with logs to prove it.
  • Also, you have to rebase on latest master and fix the conflicts.

@stale
Copy link

stale bot commented Nov 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants