Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microRTPS: add timesync #14297

Merged
merged 18 commits into from Mar 10, 2020
Merged

microRTPS: add timesync #14297

merged 18 commits into from Mar 10, 2020

Conversation

TSC21
Copy link
Member

@TSC21 TSC21 commented Mar 4, 2020

Adds timesync for the microRTPS bridge. The agent is the one responsible to initiate the time sync hand shake and compute the offset. The client, at this stage, just responds to the msgs. Eventually in the future the timesync being done on the Mavlink module will be generalised to be used also on the microRTPS client, but not need to do it right now.

@TSC21 TSC21 added this to the Release v1.11.0 milestone Mar 4, 2020
msg/timesync.msg Outdated Show resolved Hide resolved
@TSC21 TSC21 force-pushed the feature/add_rtps_timesync branch 3 times, most recently from a79e2e2 to fe1a18b Compare March 9, 2020 13:55
@TSC21 TSC21 marked this pull request as ready for review March 9, 2020 13:57
@TSC21 TSC21 force-pushed the feature/add_rtps_timesync branch from fe1a18b to a61b7fe Compare March 9, 2020 13:59
@TSC21 TSC21 requested a review from jkflying March 9, 2020 14:14
@TSC21 TSC21 force-pushed the feature/add_rtps_timesync branch from af9a154 to ff4af95 Compare March 9, 2020 14:38
@TSC21 TSC21 force-pushed the feature/add_rtps_timesync branch from 0ac4a7f to f9e0d8f Compare March 9, 2020 14:49
@TSC21 TSC21 requested a review from jkflying March 9, 2020 14:53
msg/templates/urtps/microRTPS_timesync.cpp.em Outdated Show resolved Hide resolved
msg/templates/urtps/microRTPS_timesync.cpp.em Outdated Show resolved Hide resolved
msg/templates/urtps/microRTPS_timesync.cpp.em Outdated Show resolved Hide resolved
msg/templates/urtps/microRTPS_timesync.cpp.em Outdated Show resolved Hide resolved
@TSC21 TSC21 force-pushed the feature/add_rtps_timesync branch from b29df5c to 2e85345 Compare March 9, 2020 19:57
@TSC21 TSC21 requested a review from jkflying March 10, 2020 11:33
jkflying
jkflying previously approved these changes Mar 10, 2020
Copy link
Contributor

@jkflying jkflying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more small cleanup, and I'm good.

msg/templates/urtps/microRTPS_timesync.h.em Show resolved Hide resolved
msg/templates/urtps/microRTPS_timesync.h.em Outdated Show resolved Hide resolved
@TSC21 TSC21 merged commit 04ec204 into master Mar 10, 2020
@TSC21 TSC21 deleted the feature/add_rtps_timesync branch March 10, 2020 12:15
@mrpollo mrpollo mentioned this pull request Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants