Update ecl to add ability to recover from bad magnetic yaw #14301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Mar 5, 2020
|
Huge flash overflow on fmu-v2. Looks like it might be time for something a little more drastic... |
priseborough
force-pushed
the
ekfYawResetLogging-wip
branch
from
b1e878d
to
ac9eccc
Compare
priseborough
force-pushed
the
ekfYawResetLogging-wip
branch
from
ac9eccc
to
bb655f4
Compare
priseborough
changed the title
bresch
requested changes
Mar 10, 2020
bresch
reviewed
Mar 10, 2020
src/modules/logger/logger.h
Outdated
Comment on lines
58
to
64
| #ifdef ORB_USE_PUBLISHER_RULES | ||
| static constexpr hrt_abstime TRY_SUBSCRIBE_INTERVAL {1000}; | ||
| #else | ||
| static constexpr hrt_abstime TRY_SUBSCRIBE_INTERVAL {1000 * 1000}; // interval in microseconds at which we try to subscribe to a topic | ||
| #endif |
There was a problem hiding this comment.
Removed for now. Might be less relevant after #14106. I'll readd this (or solve it differently) if needed in master.
dagar
reviewed
Mar 10, 2020
|
Fix for CI clang-tidy failure PX4/PX4-ECL#775. |
dagar
previously approved these changes
Mar 12, 2020
Tested on PixRacer V4Indoor Flight Test Procedure Notes Log https://review.px4.io/plot_app?log=e5d5c88a-6cd0-4297-880c-54328d4c2018 Tested on CUAV nano V5Indoor Flight Test Procedure Notes Log https://review.px4.io/plot_app?log=442d5bf6-b8ac-48bc-b8dc-7befe8525b27 |
priseborough
force-pushed
the
ekfYawResetLogging-wip
branch
from
5c466e4
to
dbab114
Compare
dagar
force-pushed
the
ekfYawResetLogging-wip
branch
from
63b24d5
to
30e4206
Compare
dagar
force-pushed
the
ekfYawResetLogging-wip
branch
from
30e4206
to
82a55fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to log additional data required for flight testing when ecl version updates to latest master containing PX4/PX4-ECL@4669aa6