Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mavlink_messages for HUD: send EAS instead of IAS #14858

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented May 7, 2020

This PR makes the MavlinkStreamVFRHUD send true_airspeed_m_s instead of indicated_airspeed_m_s for HUD on groundstation. This makes especially sense when your airspeed setup needs a scale factor (between indicated to equivalent), as otherwise the HUD displays another airspeed than the one that's used in the control modules.

Alternatively we could also display equivalent and not true airspeed. I would prefer true airspeed, such that it is comparable to the groundspeed.

EDIT: it would now send EAS and not TAS.

@sfuhrer sfuhrer self-assigned this May 7, 2020
@sfuhrer sfuhrer requested a review from RomanBapst May 7, 2020 17:30
@dagar
Copy link
Member

dagar commented May 7, 2020

I don't actually feel that strongly about this however...

@sfuhrer sfuhrer changed the title mavlink_messages: send TAS instead of IAS mavlink_messages for HUD: send TAS instead of IAS May 7, 2020
@hamishwillee
Copy link
Contributor

Yes, this would be a break to the spec. If you're going to do this create a PR on MAVLink with a justification that explains why this is not a problem for all the HUD systems out there. You can perhaps add a new extension field for MAVLink 2 messages if you think a HUD might need that too.

Send equivalent_airspeed_m_s instead of indicated_airspeed_m_s for HUD on groundstation.

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
@sfuhrer
Copy link
Contributor Author

sfuhrer commented May 8, 2020

@dagar I wasn't aware actually that FW att C still used IAS, made a PR to change that #14868.
I reverted to using EAS (which is equal to calibrated airspeed, CAS, on PX4).
@hamishwillee I've created a PR on mavlink mavlink/mavlink#1375. As we only have one unspecified "airspeed" field in VFR_HUD, editing the comment would be enough, but let me know what you think of that. It doesn't make sense for me to send IAS to the HUD if you have an CAS available, like we have in PX4. After a bit of internet research I think that also real airplanes usually display CAS and not IAS.

@sfuhrer sfuhrer changed the title mavlink_messages for HUD: send TAS instead of IAS mavlink_messages for HUD: send EAS instead of IAS May 8, 2020
@sfuhrer
Copy link
Contributor Author

sfuhrer commented May 13, 2020

@dagar mavlink/mavlink#1375 is merged, I guess we can then do the same here.

@sfuhrer sfuhrer merged commit b5cc3c4 into master May 18, 2020
@sfuhrer sfuhrer deleted the pr-hud-IAS-to-EAS branch May 18, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants