powerCheck: add power redundancy check #15050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Jun 8, 2020
|
This is an acceptable interim solution, but I still wonder if we need a centralized system power configuration. Something where you would explicitly configure the purpose of each available input, then the system could automatically enforce the appropriate pre-flight checks. |
A parameter spcifies what the redundancy level for 5V rail supply needs to be and a check makes sure that it's available before taking off such that the user is aware of a broken or disconnected redundant power module.
MaEtUgR
force-pushed
the
detect-missing-redundant-power-supply
branch
from
0ae4ecf
to
d812c31
Compare
I agree and I would even say the checks should not be limited to pre-flight. The user should also get a warning if something fails in air not just the next time he tries to fly. This is a minimal solution to at least notice the requirements are not met in the first place. |
dagar
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
The user is unaware of a broken or disconnected redundant power module.
Describe your solution
A parameter specifies what the redundancy level for 5V rail supply needs to be and a check makes sure that it's available before taking off.
Test data / coverage
Successfully tested with two INA266s and the redundancy level
COM_POWER_COUNTon 2 and with defaults and just INA266 or ADC power module.Additional context
Wider context is a closer review of possible power supply cases e.g. #14899