Move XML injection to the group level

[hamishwillee]

Param metadata is generated from source param definitions. The xmloutput parser also prefixes the generated parameter.xml file with additional "injected XML" that it pulls in from a local file. The problem with this is that this injected XML is not included in the generated markdown output, and would also need to be pulled into the json parameter output and any future output formats.

What this change does is import the injected XML into parameter groups and prepend these to the parameter group list before it is passed to the output generators. With this change the groups in the XML are added for any new output.

I have tested this and the output is the almost identical to the original XML.

• Generated output is better in that output field order of injected content matches all other fields.
• No fields are missing
• The only thing missing is the new output is the group attribute no_code_generation - which is not in the "official" output - see <group name="UAVCAN Motor Parameters" no_code_generation="true">

The injected params are a subset of the original XML, so does not test all possible input. I therefore ran this to round trip the generated XML- it works for all that XML too.

Note however that it has the same limitations as the original parser - It does not check for duplication of groups/params in injected content. IMO not worth the effort.

[hamishwillee]

So I guess that "no_code_generation="true">" thingy makes a difference :-(. Will look at it another day

[bkueng]

Thanks, looks good.

Not sure how this will work in UAVCAN 1 though.

[hamishwillee]

@bkueng Great. You'll have to merge too; I can't.

Not sure how this will work in UAVCAN 1 though.

Fair enough. But if this approach doesn't work for UAVCAN1 we'd probably have had to revisit anyway.