Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process_sensor_caldata.py: skip accel or gyro if temperature is NAN #15644

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 28, 2020

@NicolasM0
Copy link
Contributor

If thermal compensation is enabled but a sensor id is not found in TC_* parameters, an error appear:
ERROR [temperature_compensation] gyro init: failed to find device ID 4325386 for instance 2

@dagar
Copy link
Member Author

dagar commented Aug 31, 2020

If thermal compensation is enabled but a sensor id is not found in TC_* parameters, an error appear:
ERROR [temperature_compensation] gyro init: failed to find device ID 4325386 for instance 2

I was considering that to be a feature. Would you like to change it?

@dagar dagar merged commit 0b0d23e into master Aug 31, 2020
@dagar dagar deleted the pr-temp_cal_nan branch August 31, 2020 11:59
@NicolasM0
Copy link
Contributor

I was thinking that this file should be changed to add the sensor id in parameters even if temperature is nan and let other TC_* par for this sensor to 0 to avoid this error.

@dagar
Copy link
Member Author

dagar commented Aug 31, 2020

I was thinking that this file should be changed to add the sensor id in parameters even if temperature is nan and let other TC_* par for this sensor to 0 to avoid this error.

That could work, although I have a slight preference for not carrying the dead weight. If anything I was more interested in the case where the sensor is calibrated against a different temperature source (perhaps configurable per instance), however it doesn't seem in that Bosch case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants