-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sensors/vehicle_gps_position: untangle and remove unnecessary state #15827
Conversation
Relatedly, now that GPS blending has moved to the sensors hub we can think about expanding it slightly for Multi-EKF (#14650).
We also need to add per instance metadata at the sensors level instead of single set of position offsets in EKF2.
|
float min_alpha = constrain(omega_lpf * 1e-6f * (float)(_gps_state[i].timestamp - _time_prev_us[i]), | ||
0.0f, 1.0f); | ||
|
||
// scale the filter coefficient so that time constant is inversely proprtional to weighting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't that useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it was removed back in ekf2, but somehow got lost in the drawn out PR sitting around for 6 months.
8de1f52#diff-72bb106f8fdfef0de0e8174f5b63ad2987bd47a8f07ff445bde40a812c87651e
c0751e5
to
129dd31
Compare
A lot of the state has been removed, but this is still hard to follow. Let's layout a simple test plan here. |
Just took a brief look through, and seems ok - I'll give myself a TODO to try it out with a couple GPSs on a real board, and capture logs. |
129dd31
to
78c61a1
Compare
@dagar to be clear, all I did for testing was ensure that two |
Thanks @JacobCrabill |
@JacobCrabill @bresch this is the refactor/cleanup of GPS blending originally from #14447.
NOT TESTED.
This would be a good excuse to add proper testing in SITL for GPS blending and perhaps even restructure the blending logic to make it unit testable.