sensor calibration: apply board level adjustment to external sensors #16127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bresch
approved these changes
Nov 6, 2020
bresch
requested changes
Nov 10, 2020
priseborough
approved these changes
Nov 10, 2020
|
I think FW users should be encouraged to use https://dev.px4.io/master/en/advanced/parameter_reference.html#FW_PSP_OFF instead of a level calibration to adjust the pitch/AoA required to maintain height. |
I agree. |
bresch
approved these changes
Nov 12, 2020
mvacanti
pushed a commit
to mvacanti/PX4-Autopilot
that referenced
this pull request
Nov 27, 2020
…X4#16127) - apply SENS_BOARD_{X,Y,Z}_OFF to external sensors to prevent unnecessary misalignment with internal IMU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially a quick interim solution for #16126.