Control Zero F7 - Fix for voltage/current sensing #16590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to enable standard current/voltage sensor to display voltage and current readings.
dagar
reviewed
Jan 19, 2021
| @@ -175,7 +175,7 @@ | |||
| #define BOARD_ADC_USB_CONNECTED (px4_arch_gpioread(GPIO_OTGFS_VBUS)) | |||
| #define BOARD_ADC_USB_VALID BOARD_ADC_USB_CONNECTED | |||
| #define BOARD_ADC_SERVO_VALID (1) /* never powers off the Servo rail */ | |||
| #define BOARD_ADC_BRICK_VALID (!px4_arch_gpioread(GPIO_nVDD_BRICK1_VALID)) | |||
| #define BOARD_ADC_BRICK_VALID (px4_arch_gpioread(GPIO_nVDD_BRICK1_VALID)) | |||
There was a problem hiding this comment.
So GPIO_nVDD_BRICK1_VALID is actually GPIO_VDD_BRICK1_VALID? If so can you rename it?
There was a problem hiding this comment.
Ok, it is renamed to GPIO_VDD_BRICK1_VALID (if I understood correctly that is what you were after but that would be different than the naming convention of everything else I could see).
Renaming GPIO_nVDD_BRICK1_VALID to GPIO_VDD_BRICK1_VALID
Renamed GPIO_nVDD_BRICK1_VALID to GPIO_VDD_BRICK1_VALID
|
Confirmed working?
|
|
Confirmed working.
|
dagar
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to enable standard current/voltage sensor to display voltage and current readings on Control Zero F7.