Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use range finder for height control instead of height aiding #18864

Closed
wants to merge 1 commit into from

Conversation

bresch
Copy link
Member

@bresch bresch commented Dec 16, 2021

PR opened for discussion.

This is another step required to enable simultaneous baro and GPS height aiding.

Describe problem solved by this pull request
Range aid was introduced to stabilize the EKF estimates during takeoff and landing of large vehicle having their barometer highly affected by ground effects.

This feature has undesired effects on the reference altitude given that it produces measurements relative to a different datum
(i.e.: the ground). While switching in and out of range aid, the estimator accumulates an offset that can grow over time (known as ratcheting), leading to an undesired offset of the estimated global position.

Describe your solution
After discussion with @priseborough , it has been agreed that the range finder should only be used as an assistance for takeoff and landing in the height controller and not as an aiding source for navigation.

TODO:

  • verify terrain hold logic in MC pos control
  • allow to use dist_bottom for auto takeoff and landing

Range aid was introduced to stabilize the EKF estimates during takeoff
and landind of large vehicle having their barometer highly affected by
ground effects.
This feature has undesired effects on the reference altitude given that
it produces measurements relative to a different datum
(i.e.: the ground). While switching in and out of range aid, the estimator
accumulates an offset that can grow over time (known as ratcheting),
leading to an undesired offset of the estimated global position.

After discussion, it has been agreed that the range finder should only
be used as an assistance for takeoff and landing in the height
controller and not as an aiding source for navigation.
@bresch bresch added the EKF2 label Dec 16, 2021
@bresch bresch self-assigned this Dec 16, 2021
@priseborough
Copy link
Contributor

priseborough commented Dec 21, 2021

For vehicles where the Baro disturbance in ground effect is higher than the EKF's ability to compensate, removing this feature will require them to use GPS for height with a reduction in robustness to GPs glitches or IMU clipping during up and away flight. I don't know how many users would be affected in this way. Other that this I don't see any blockages to removal of this feature. If we leave it in, the documentation would need to be updated to clearly caveat the intended use.

@bresch
Copy link
Member Author

bresch commented Aug 12, 2022

Replaced by #19944 where the range finder can be used during landing to stabilize the EKF without changing the height reference

@bresch bresch closed this Aug 12, 2022
@bresch bresch deleted the pr-range-aid-rip branch August 12, 2022 12:36
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/distance-sensor-faulty-readings-affecting-local-position-estimate-significantly-px4-v1-11-3/35924/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants