Levenberg-Marquardt fitting for sensor calibration #18882
Draft
+169
−196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a new Levenberg-Marquardt fitting for sensor calibration. It optimizes scales and offsets (without off-diagonals). It could be used for accel calibration as discussed here #18166.
As a first step, the existing code is factorized.
and then a new fitting ("ortogonal_ellipsoid") is added.
This is a draft and it can certainly be improved. I am not sure how to make it cleaner. I could define an "algorithm" class from which each specific algorithm can inherit.
Not tested much for now but I have done 3 mag calibrations: one with the actual code, one with my new implementation (should have the same results but as input data are not the same...), and one with the new orthogonal_ellipsoid method (not aimed to be used for mag calibration but just to see if it works).