Move serial passthru config from board Kconfig to systemcmds/serial_passthru Kconfig #19127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davids5
changed the title
davids5
force-pushed
the
pr-serial_passthru-config
branch
from
c006537
to
0c94816
Compare
dagar
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19116 enabled consolidating sub setting into a module, driver, or systemcmds) Kconfig and accessing them in code.
This PR is using that scheme for serial_passthru.
It also select by default the path from CONFIG_BOARD_SERIAL_GPS1 device for the cdc_acm_check launcher but allows it to be overridden to any of the defined CONFIG_BOARD_SERIAL_GPSn.