Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuttX with test code for stm32:Discard data with Parity Errors #19446

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davids5
Copy link
Member

@davids5 davids5 commented Apr 6, 2022

This is for testing the NuttX change for STM32 F1, F4 dropping of Serial data with bad parity.

It will be repointed to NuttX back ports once testing is done.

@davids5 davids5 requested a review from dagar April 6, 2022 16:51
@davids5
Copy link
Member Author

davids5 commented Apr 6, 2022

@farhangnaderi - this is for testing PX4/NuttX#182

@dagar
Copy link
Member

dagar commented Apr 12, 2022

Rebased on master and px4io binaries updated.

@farhangnaderi
Copy link
Contributor

farhangnaderi commented Apr 13, 2022

Some tests with 5X:
Was windy so I did not go high that much. But some other interesting things happened like Arming with High throttle and GPS2 which is not connected at the beginning and I have to connect reconnect the plug to recognize it.
https://review.px4.io/plot_app?log=df47acfd-cfc1-4d83-bad7-554cc0689a16
https://review.px4.io/plot_app?log=52525145-8f8a-4e06-a727-eb990e567388
https://review.px4.io/plot_app?log=fe61e1fb-8490-4f75-8bae-765c155b9d23
https://review.px4.io/plot_app?log=aee3f562-a20a-4b3e-9b43-52e822108530
https://review.px4.io/plot_app?log=fdb9f522-1fb5-4bd0-8f9d-1f6692fe4ec9

@davids5
Copy link
Member Author

davids5 commented Jul 8, 2022

@farhangnaderi - please rested with FMU:V2, V4 V5

@farhangnaderi
Copy link
Contributor

My Pixracer MicroSD has issues I think. Corrupted files. Will test again with another card and Pixhawk4 as well.
https://review.px4.io/plot_app?log=21c946f3-f626-4eea-be76-fbc08a60c5d2
https://review.px4.io/plot_app?log=cacc847a-c4a9-4428-99cf-eb0f59e268a2

@farhangnaderi
Copy link
Contributor

farhangnaderi commented Jul 22, 2022

@davids5 with v5 (Pixhawk 4). The strange thing is I was not able to switch to position mode. My range sensor is Lightware by the way.
https://review.px4.io/plot_app?log=9fe64053-97ed-429a-881d-c519da9493d2
https://review.px4.io/plot_app?log=1d81a956-2a96-4499-8ebf-fb8fae32d2be
https://review.px4.io/plot_app?log=0cc5d236-899a-4f47-bbf2-24e09536713e

Also this one with v4 (Pixracer) which I was able to successfully switch to Position mode but didnt fly with it yet. Will share another set of logs next day:
https://review.px4.io/plot_app?log=8ca30321-c94a-492a-b578-6b2502a05ff7

@farhangnaderi
Copy link
Contributor

@davids5
Copy link
Member Author

davids5 commented Jul 28, 2022

@farhangnaderi

I am having trouble understanding if the results and issues you see are related to the changes in the PR or how you are testing.

I have rebased this on current master can you A B test the FWs master to PR on the same HW without any changes other than downloading the FW on a V2 (test the IO and F4) and a V4 (test the F4).

What matters is ONLY the things connected by U[S}ART ports. (RC that id SBUS, GPS, TELEMs.)

Please list the HW connected.

Thank you

@farhangnaderi
Copy link
Contributor

farhangnaderi commented Aug 31, 2022

Might be a bit late. The hardware on my Pixracer frame are as below:

  1. GPS: https://store.mrobotics.io/product-p/gps001-mr.htm
  2. RC: Radiolink R12DSM
  3. Telem: Holybro 500mW

Two logs with Stabilized and master. Will add Position ones tomorrow,
https://review.px4.io/plot_app?log=e5cc4619-a642-400b-babd-aff4a7ac4250
https://review.px4.io/plot_app?log=e28957f4-a866-46c7-be11-3c36cbbe051e

Added with Position mode as promised:
https://review.px4.io/plot_app?log=6b897a09-18cd-4b55-935b-c0e58442c029
https://review.px4.io/plot_app?log=6904d0b8-c993-480d-b44c-4635b124c72d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants