Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tailsitter frame conventions #21573

Merged
merged 1 commit into from May 10, 2023
Merged

Conversation

Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented May 10, 2023

Solved Problem

Previously, the tailsitter control axis of the fixed wing and multicopter had to be switched.

This has been changed in #21319, but has not been applied to the differential thrust control for attitude control

Solution

Remove the axis switching when copying torque setpoints for tailsitters

Test coverage

Context

Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, thanks for the fix! The change that broke it was though #20904 and not the linked PR in the description.

@Jaeyoung-Lim Jaeyoung-Lim merged commit 47e802e into main May 10, 2023
82 of 86 checks passed
@Jaeyoung-Lim Jaeyoung-Lim deleted the pr-fix-tailsitter-differential branch May 10, 2023 13:33
@julianoes
Copy link
Contributor

Wow that's confusing. Are all these different frames somewhere explained?

@sfuhrer
Copy link
Contributor

sfuhrer commented May 11, 2023

Wow that's confusing. Are all these different frames somewhere explained?

You mean the fw vs mc resp. torque_sp instance 0 vs 1? The best we have is https://docs.px4.io/main/en/flight_stack/controller_diagrams.html#vtol-flight-controller, which needs an update after switching to the control allocation topics.
Or do you mean the airspeed (FW) vs the body frame?

@julianoes
Copy link
Contributor

julianoes commented May 11, 2023

Ok, I guess it makes sense looking at the docs. And then yaw goes to roll, pitch to pitch, and roll to yaw, because it's a tailsitter. Got it. Thanks!

bresch pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants