lights: Add LP5562 RGBLED driver #21649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
May 30, 2023
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-maintainers-call-may-30-2023/32372/1 |
julianoes
force-pushed
the
pr-rgbled-lp5562
branch
from
7101a46
to
1e86cf6
Compare
julianoes
force-pushed
the
pr-rgbled-lp5562
branch
from
1e86cf6
to
563179b
Compare
hamishwillee
reviewed
Jun 1, 2023
julianoes
force-pushed
the
pr-rgbled-lp5562
branch
2 times, most recently
from
1f3b90c
to
67af398
Compare
This adds support for the TI LP5562 RGB LED driver. Things to note: - The driver is initialized in simple PWM mode using its internal clock, for R,G,B, but not for W(hite). - The chip doesn't have a WHO_AM_I or DEVICE_ID register to check. Instead we read the W_CURRENT register that we're generally not using and therefore doesn't get changed. - The current is left at the default 17.5 mA but could be changed using the command line argument. Datasheet: https://www.ti.com/lit/ds/symlink/lp5562.pdf Signed-off-by: Julian Oes <julian@oes.ch>
julianoes
force-pushed
the
pr-rgbled-lp5562
branch
from
67af398
to
f97b8c6
Compare
|
It looks like CI is the same as main, so I'll merge this now so I can backport it to v1.14 in time. Thanks for the reviews! |
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-maintainers-call-june-06-2023/32473/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the TI LP5562 RGB LED driver.
Things to note:
Datasheet:
https://www.ti.com/lit/ds/symlink/lp5562.pdf
Tested on the bench using a Pixhawk 6X.
This is required for some of the Holybro products switching to it.
FYI @vincentpoont2.
Needs backporting to v1.14.