temperature_compensation: use snprintf instead of sprintf #21870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because sprintf is deprecated on MacOS and CI fails with warning -> error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
MacOS CI failing with:
Solution
Use snprintf with the buffer limit since it's better practise and hopefully will fix MacOS CI.
Changelog Entry
Alternatives
There are many more sprintfs mostly in the xrce log functionality (submodule) but apparently that's not compiled by default for SITL.
Test coverage
Builds locally on Ubuntu, let's see what MacOS CI does.
Context
Example failed build: https://github.com/PX4/PX4-Autopilot/actions/runs/5602138930/jobs/10246984717