Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ekf2: add kconfig option to disable mag, switch holybro kakutef7 to ekf2 #22030

Merged
merged 6 commits into from
Sep 15, 2023

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 31, 2023

Disabling magnetometer support in ekf2 saves ~ 24.5 kB of flash.

FYI @julianoes @bkueng

@dagar dagar requested a review from bresch August 31, 2023 17:22
@dagar dagar added the EKF2 label Aug 31, 2023
@dagar dagar force-pushed the pr-ekf2_kconfig branch 3 times, most recently from 4f6a7bc to 0ecfd88 Compare August 31, 2023 20:54
@bkueng
Copy link
Member

bkueng commented Sep 1, 2023

Nice, how much does it add now (bloaty ci comparison fails)?

Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it also forces us to group the variables and functions together

src/modules/ekf2/EKF/yaw_update.cpp Outdated Show resolved Hide resolved
src/modules/ekf2/EKF/yaw_update.cpp Outdated Show resolved Hide resolved
@dagar dagar merged commit 153f7bb into main Sep 15, 2023
87 checks passed
@dagar dagar deleted the pr-ekf2_kconfig branch September 15, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants