stm32h7_can: fix filter memory initialization bug. #22043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@duartecdias please run |
|
@davids5 , let me know if ok to merge (MAVROS tests failing BTW..) |
|
@dagar is HW CI Down? |
|
@duartecdias - MAVROS look unrelated (as it should be) but I would like to see HW CI happy first. |
dagar
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the reception of the feedback from KDECAN ESCs in the following public branch (https://github.com/duartecdias/PX4-Autopilot/tree/pr/uavcan/kdecanProtocol), it was noted that while using standard ids, some messages were not being received from the ESCs in a random fashion for different power cycles.
Problem was tracked down to the initialization of the filters (probably they are being initialized randomly at each power cycle). After proper memset of the respective filter areas the problem went away.
Also adjusted the number of maximum filters for extended IDs to 64, according to the h7 chip datasheet.