Craziflie configs: remove default 100% thrust parameter #22082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When browsing through the maximum thrust settings of different airframes I found that the Crazyflies config sets the default to the same value as the default which is 100% thrust.
Since #9359 the default is 100% thrust and when the parameter for the Crazyflie was commited that was already there: 28f616b#diff-0c848f9e92ff14731d314da17e247ea2312673f6c8018c94c9a22153419e79d9R41
Solution
Don't set the global default as airframe default with no apparent reason.
Changelog Entry
Test coverage
I'm certain the value stays the same.