Remove outdated / discontinued airframe configs #22453
Conversation
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
| @@ -1,91 +0,0 @@ | |||
| #!/bin/sh | |||
| # | |||
| # @name Crazyflie 2 | |||
There was a problem hiding this comment.
This could probably be merged with the 4901_crazyflie21, but it might be better to leave it alone unless you want to review in detail.
What I actually wanted to do in special cases like the crazyflie is have an airframe that's part of the board support rather than carried centrally like we have now.
There was a problem hiding this comment.
Additionally special boards like the crazyflie could have ONLY their airframe and not even include the full selection in the build.
There was a problem hiding this comment.
ah we still support the build of the crazyflie 1?
PX4-Autopilot/.ci/Jenkinsfile-compile
Line 51 in f00d97d
There was a problem hiding this comment.
should I bring it back or can we even remove the support for the build target?
There was a problem hiding this comment.
I don't have the full context of who is using a Crazyflie and what version but this seems to be the last real update to the airframe: #9514 which makes me assume no one even tested if the latest version still works.
| @@ -1,35 +0,0 @@ | |||
| #!/bin/sh | |||
| # | |||
| # @name Holybro S500 | |||
There was a problem hiding this comment.
I'm not sure about this one. I mean it's hardly worth more than "generic quad", but if anyone has this airframe selected and it disappears its a terrible user experience (parameters lost, etc).
There was a problem hiding this comment.
Fair point. I've reverted the removal.
Going forward we really only should allow airframe configs into main that have a huge benefit for the whole community, and will likely be supported for a long time. Otherwise we end up with a big graveyard with airframes that people keep using but are not maintained.
I much prefer to let users select a generic airframe and then do the output mapping themselves, ideally with a section in the user guide about the specif airframe bringup.
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
sfuhrer
force-pushed
the
pr-clean-up-airframes-main
branch
from
f3bdd43
to
85fa43f
Compare
| @@ -1,91 +0,0 @@ | |||
| #!/bin/sh | |||
| # | |||
| # @name Crazyflie 2 | |||
There was a problem hiding this comment.
I don't have the full context of who is using a Crazyflie and what version but this seems to be the last real update to the airframe: #9514 which makes me assume no one even tested if the latest version still works.
|
qgc不能控制crazyflie 2.1的电机是怎么回事 |
Saves a bit of flash (1kB) and removes airframes that anyway are not actively supported. Better have less and better maintained airframes than the opposite.
Could also have a discussion whether we need to keep the Mantis EDU, as it's also not possible to buy it anywhere afaik.