[rc.simulator] fix PX4_HOME_ALT and cleanup #22562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frede791
reviewed
Dec 18, 2023
| fi | ||
|
|
||
| else | ||
| if ! gz_bridge start -p "${model_pose}" -m "${PX4_SIM_MODEL#*gz_}" -w "${PX4_GZ_WORLD}" -i "${px4_instance}"; then | ||
| echo "ERROR [init] gz_bridge failed to start" |
There was a problem hiding this comment.
Can we maybe make these errors a bit more verbose by providing a reason why gz-bridge failed to start? Otherwise there is the same error message in two different if-statements.
There was a problem hiding this comment.
@frede791 , at the rc.simulator scope, there is no way to know what caused the bridge to fail to start. Nevertheless I distiguished the two cases: starting and spawning VS starting and attaching to existing vehicle
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
beniaminopozzan
force-pushed
the
pr-fix-rc.simulator
branch
from
ced3063
to
e3e6c87
Compare
dagar
reviewed
Dec 18, 2023
Co-authored-by: Daniel Agar <daniel@agar.ca>
dagar
reviewed
Dec 18, 2023
Co-authored-by: Daniel Agar <daniel@agar.ca>
dagar
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
SIM_GZ_HOME_ALTwas uncorrectly set.Additional feature
Increase documentation of Gazebo simulation startup