px_process_events: fix empty base path being a list #22570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This make `make extract_events` fail in CI that only runs on the main branch and hence I wasn't aware of.
MaEtUgR
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
After merging #22551 I was informed by @dagar that the additional CI command
make extract_eventswhich only runs on the main branch fails 馃槵I actually tested an empty base path but in between testing and pushing I changed the
base-pathparameter to a single string instead of a list, forgot to adjust the default and didn't test again. Sorry for that.Solution
Adapt parameter to return an empty string instead of an empty string in a list after changing it to a single argument instead of multiple.
Changelog Entry
Test coverage
I ran the command locally and verified the path was processed like before the change.