Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROMFS: respect kconfig for including romfs files (airframes, etc) #22571

Merged
merged 3 commits into from
Feb 23, 2024
Merged

ROMFS: respect kconfig for including romfs files (airframes, etc) #22571

merged 3 commits into from
Feb 23, 2024

Conversation

dagar
Copy link
Member

@dagar dagar commented Dec 20, 2023 •
edited

This saves ~8.1 kB of flash on px4_fmu-v6x_default.

@dagar dagar force-pushed the pr-romfs_includes_kconfig_dep branch from f0d8a4a to 5a3cc85 Compare December 20, 2023 00:48
sfuhrer
sfuhrer previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I see nothing speaking against it. Helps also as a small step towards separating the airframe types.

@MaEtUgR MaEtUgR force-pushed the pr-romfs_includes_kconfig_dep branch from 5a3cc85 to 0361568 Compare December 21, 2023 17:00
MaEtUgR
MaEtUgR approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for that proposal. I rebased on main and added differential rover.

@github-actions github-actions bot added stale and removed stale labels Jan 21, 2024
@MaEtUgR
Copy link
Member

MaEtUgR commented Jan 31, 2024 •
edited

ok, I'm testing on a v5x with all the Kconfig interesting options disabled. I can only choose the balloon airframe then and dmesg complains about SDLOG parameters missing which is to be expected since the balloon airframe seems to set them because it's used for logging and telemetry. Maybe we'll make it a logging-only airframe instead of a specific balloon 🤔 QGC still shows all airframes to choose from, which is something we'll need to fix for a good user experience with modular builds.
image

MaEtUgR
MaEtUgR previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do a follow-up to clean up the balloon airframe.

@MaEtUgR MaEtUgR self-assigned this Feb 13, 2024
@MaEtUgR MaEtUgR force-pushed the pr-romfs_includes_kconfig_dep branch from a83256b to 32820cf Compare February 15, 2024 13:45
MaEtUgR
MaEtUgR approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@MaEtUgR MaEtUgR left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased on main and adapted the differential drive module name.
Can we merge?

@MaEtUgR
Copy link
Member

MaEtUgR commented Feb 20, 2024

Quickly test logger and temperature calibration being there and running. Better safe than sorry.

@PerFrivik
Copy link
Contributor

Tested logger and temperature calibration 👍, works as intended.

@MaEtUgR MaEtUgR merged commit b2b7439 into main Feb 23, 2024
90 of 92 checks passed
@MaEtUgR MaEtUgR deleted the pr-romfs_includes_kconfig_dep branch February 23, 2024 14:40
jwwaite pushed a commit to AIVS-Inc/PX4-Autopilot that referenced this pull request Feb 24, 2024
@dagar @MaEtUgR @jwwaite
ROMFS: respect kconfig for including romfs files (airframes, etc) (PX…
695660a 
…4#22571)

* ROMFS: respect kconfig for including romfs files (airframes, etc)

* ROMFS: only add R1 airframe with differential drive control

* ROMFS: adapt to differential drive module renaming

---------

Co-authored-by: Matthias Grob <maetugr@gmail.com>
avcuenes pushed a commit to avcuenes/PX4-Autopilot that referenced this pull request Feb 28, 2024
@dagar @MaEtUgR @avcuenes
ROMFS: respect kconfig for including romfs files (airframes, etc) (PX…
7f44ef6 
…4#22571)

* ROMFS: respect kconfig for including romfs files (airframes, etc)

* ROMFS: only add R1 airframe with differential drive control

* ROMFS: adapt to differential drive module renaming

---------

Co-authored-by: Matthias Grob <maetugr@gmail.com>
Peize-Liu pushed a commit to Peize-Liu/PX4-Autopilot that referenced this pull request Mar 24, 2024
@dagar @MaEtUgR @Peize-Liu
ROMFS: respect kconfig for including romfs files (airframes, etc) (PX…
de46be0 
…4#22571)

* ROMFS: respect kconfig for including romfs files (airframes, etc)

* ROMFS: only add R1 airframe with differential drive control

* ROMFS: adapt to differential drive module renaming

---------

Co-authored-by: Matthias Grob <maetugr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaEtUgR MaEtUgR MaEtUgR approved these changes

@PerFrivik PerFrivik PerFrivik approved these changes

@sfuhrer sfuhrer sfuhrer left review comments

Assignees

@MaEtUgR MaEtUgR

Labels
None yet
Projects
PX4 Misc
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagar @MaEtUgR @PerFrivik @sfuhrer