Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix library improvements #22580

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Matrix library improvements #22580

merged 4 commits into from
Jan 30, 2024

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Dec 21, 2023

Solved Problem

When @jwidauer helped me investigating for #22574 he had many suggestions to improve the matrix library.

Solution

Here I sorted out some low-hanging fruits he added in the code and I did some small additions.

  • Include chain, don't include "math.h" everywhere and generate circular dependencies
  • Slice templated on Matrix const and non-const case -> SliceT, ConstSlice
  • Some simplifications to not repeat the type of the return value, using Vector3 where it makes sense, ...

Changelog Entry

Cleanup: matrix library improvements

Test coverage

Build and unit tests still work

@dagar dagar merged commit 3e183fe into main Jan 30, 2024
90 checks passed
@dagar dagar deleted the matrix-improvements branch January 30, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants